Fix Rickshaw/D3 version mismatch. #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 I assume this is tested on /graph and console templates. |
When Rickshaw was updated to 1.5.1 in fd43daf, the Rickshaw upstream package now contained 3 different D3 files: d3.min.js d3.v2.js d3.v3.js For details on why that is, see https://groups.google.com/forum/#!topic/d3-js/lXQgKA7mtEw For the 1.5.1 Rickshaw to work properly (being able to format dates with D3 without causing a JS error), it needs d3.v2.js or d3.v3.js, not the d3.min.js one. I chose to update us to d3.v3.js now, since that is the most recent and minified version, and I didn't see any problems with it (also, the current Rickshaw examples are using that D3 version). Currently, displaying graphs with a range >14d is broken. This fixes that.
juliusv
force-pushed
the
fix-d3-version
branch
from
da33015 to
b3978fe
Compare
|
@brian-brazil Actually, my brain being weird as it is, I forgot about the existence of consoles again. Fixed. |
juliusv
added a commit
that referenced
this pull request
Feb 2, 2015
Fix Rickshaw/D3 version mismatch.
codesome
pushed a commit
to codesome/prometheus
that referenced
this pull request
Jul 29, 2019
Signed-off-by: Krasi Georgiev <kgeorgie@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Rickshaw was updated to 1.5.1 in
fd43daf,
the Rickshaw upstream package now contained 3 different D3 files:
d3.min.js
d3.v2.js
d3.v3.js
For details on why that is, see
https://groups.google.com/forum/#!topic/d3-js/lXQgKA7mtEw
For the 1.5.1 Rickshaw to work properly (being able to format dates with
D3 without causing a JS error), it needs d3.v2.js or d3.v3.js, not the
d3.min.js one. I chose to update us to d3.v3.js now, since that is the
most recent and minified version, and I didn't see any problems with it
(also, the current Rickshaw examples are using that D3 version).
Currently, displaying graphs with a range >14d is broken. This fixes
that.
@beorn7 @brian-brazil