Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get some todos done #489

Merged
merged 5 commits into from
Jan 29, 2015
Merged

Get some todos done #489

merged 5 commits into from
Jan 29, 2015

Conversation

beorn7
Copy link
Member

@beorn7 beorn7 commented Jan 29, 2015

@juliusv Fix a bunch of minor TODOs, see commit descriptions for details.

Bjoern Rabenstein added 5 commits January 29, 2015 12:57
Previously, it would return an error instead. Now we can distinguish
the cases 'error while deleting known key' vs. 'key not in index'
without testing for leveldb-internal kinds of errors.
persistence.go is way too long anyway, and a lot of code is just crash
recovery, which is not important to understand the normal operation.

Also, remove unused `exists` function.
Previously, those were simply deleted. The orphaned files can now be
used for forensics if needed.
@juliusv juliusv changed the title Beorn7/get some todos done Get some todos done Jan 29, 2015
@juliusv
Copy link
Member

juliusv commented Jan 29, 2015

👍

beorn7 added a commit that referenced this pull request Jan 29, 2015
@beorn7 beorn7 merged commit 5f27629 into master Jan 29, 2015
@beorn7 beorn7 deleted the beorn7/get-some-todos-done branch January 29, 2015 16:00
simonpasquier pushed a commit to simonpasquier/prometheus that referenced this pull request Oct 12, 2017
codesome pushed a commit to codesome/prometheus that referenced this pull request Jul 29, 2019
charleskorn pushed a commit to charleskorn/prometheus that referenced this pull request Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants