config: set default region for EC2 SD #2789
Conversation
mtanda
force-pushed
the
aws_default_region
branch
from
f18fa37 to
a1ddab4
Compare
|
I forgot to mention maintainers. @brian-brazil Would you check this PR? |
config/config.go
Outdated
| @@ -1126,7 +1128,13 @@ func (c *EC2SDConfig) UnmarshalYAML(unmarshal func(interface{}) error) error { | |||
| return err | |||
| } | |||
| if c.Region == "" { | |||
| return fmt.Errorf("EC2 SD configuration requires a region") | |||
| sess := session.Must(session.NewSession()) | |||
There was a problem hiding this comment.
Sounds like this could panic if something goes wrong. Better to check potential errors?
There was a problem hiding this comment.
The errors seems to be caused by wrong configuration.
https://github.com/aws/aws-sdk-go/blob/v1.8.35/aws/session/session.go#L100
https://github.com/aws/aws-sdk-go/blob/v1.8.35/aws/session/session.go#L257
https://github.com/aws/aws-sdk-go/blob/v1.8.35/aws/session/session.go#L335
https://github.com/aws/aws-sdk-go/blob/v1.8.35/aws/session/session.go#L339
https://github.com/aws/aws-sdk-go/blob/v1.8.35/aws/session/session.go#L352
But it is better to add error handling, so I add it :-)
I think..., the |
|
@fabxc @brian-brazil How I can proceed this PR? |
|
My bad, looks all good. Thanks! |
|
Thanks!! |
If Prometheus is running on EC2, most of the case
regionmight be same region where Prometheus is running.I want to set default region for the case.