Add logger injection into discovery services #2667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry about not taking a look at this earlier. There still seem to be conflicts, but LGTM in general. |
|
Oh I completely missed this as well. I was actually looking into doing this some time soon as well. Awesome work! Greatly appreciated! |
|
@fabxc right on, sorry about that. Trying to fix 'em now |
goller
force-pushed
the
go-discovery-logger
branch
from
2962531 to
42de0ae
Compare
|
@fabxc conflicts resolved! |
|
Thank you! One step closer to getting rid of globals :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there, in this PR I updated the discovery services to take a prometheus logging interface to allow logger injection. Previously, the discovery services except k8s and triton were using the base logger.
I did this because I'm interested in using the discovery package as a library and use my own logger rather than the base logger.