Improve DNS error reporting and update to current miekg/dns #2153
Conversation
This is to pull in bug fixes. However, it also requires code changes, see next commit.
When hitting the 64kiB limit of DNS, the error message so far was really misleading.
|
Re-fixes #360. |
|
LGTM - but having some integration tests for this would be useful. BTW: I'm pretty sure I ran into the 64k limit back then already and up till today I'm surprised this limit so barely known.. I still haven't found anything stating that "64k is max". IIRC this limit was due to the limit of a pointer or something. |
|
@discordianfish Surely integration tests would be great. If you have something up your sleeves, you'd make us all very happy. There is a 2byte field for the payload size in DNS, so more than 64k cannot be expressed. |
|
@brian-brazil Does this look good to you? With this in, I could cut 1.2.3 |
|
👍 |
|
Yes. To be clear: The existing implementation had worked alright. Just that it said "No servers could be reached" instead of "truncated despite using TCP". |
We hit the 64kiB limit at SC on Monday, and the error message was so misleading that a major treasure hunt ensued.
While investigating, I incorporated the update to the current miekg/dns, inspired by @discordianfish
@brian-brazil @fabxc @matthiasr whoever…