Cut release 1.3.0 #2144
Cut release 1.3.0 #2144
Conversation
|
lgtm 👍 let's get it out there |
|
Can we have #2143 in there to fix that nasty bug? |
|
i.e. you can still trigger the same panic with a negative staleness delta on the command line, and there might be other paths to the range query that would still allow the inverted time range. |
|
#2143 is in there, see last line in changelog. |
|
Ah, I didn't even see that one, thanks. I'll blame it on the jetlag :) |
|
@beorn7 your PR is merged, changes merged back into master and release-1.3 respectively. |
| @@ -9,6 +9,7 @@ This is a breaking change to the Kubernetes service discovery. | |||
| * [ENHANCEMENT] Add Azure SD metrics. | |||
| * [ENHANCEMENT] Add fuzzy search to `/graph` textarea. | |||
| * [ENHANCEMENT] Always show instance labels on target page. | |||
| * [BUGFIX] Validate query end time is not before start time. | |||
There was a problem hiding this comment.
Perhaps add that negative staleness deltas are now rejected when provided no the command line? (In principle, somebody might have done so, and now the server wouldn't start up anymore.)
|
Thanks. Just one comment about the changelog. |
|
Theoretically a breaking change – but as it caused the server to panic, categorizing it as bug fix seems fine. |
|
Exactly. 👍 |
@beorn7