Add Chunk.Utilization() methods #2055
Merged
+17
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beorn7
reviewed
Oct 6, 2016
| @@ -322,6 +322,11 @@ func (c varbitChunk) UnmarshalFromBuf(buf []byte) error { | |||
| // encoding implements chunk. | |||
| func (c varbitChunk) Encoding() Encoding { return Varbit } | |||
|
|
|||
| // Utilization implements chunk. | |||
| func (c varbitChunk) Utilization() float64 { | |||
| return float64(c.nextSampleOffset()) / float64(cap(c)) | |||
There was a problem hiding this comment.
You might want to count the footer part at the end of the chunk as used, too. Not sure about the exact math, but with the current implementation, your utilization can never reach 100% (which might or might not be what you want).
|
Just a math nit. Decide yourself what you need for your use case. Otherwise 👍 |
When using the chunking code in other projects (both Weave Prism and ChronixDB ingester), you sometimes want to know how well you are utilizing your chunks when closing/storing them.
|
Updated varbit utilization function together with @beorn7. |
|
👍 from @beorn7 in person |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the chunking code in other projects (both Weave Prism and
ChronixDB ingester), you sometimes want to know how well you are
utilizing your chunks when closing/storing them.