Simplify and fix remote write example #2053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brian-brazil
reviewed
Oct 5, 2016
| // AppenderHandler returns a http.Handler that accepts proto encoded samples. | ||
| func AppenderHandler(s WriteServer) http.Handler { | ||
| return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { | ||
| http.HandleFunc("/push", func(w http.ResponseWriter, r *http.Request) { |
There was a problem hiding this comment.
Would /receive be better?
|
👍 |
After removing gRPC, this can be simplified again. Also, the configuration for the remote storage moved from flags to the config file.
juliusv
force-pushed
the
fix-remote-write-example
branch
from
3c2f63e to
b516335
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After removing gRPC, this can be simplified again. Also, the
configuration for the remote storage moved from flags to the config
file.