Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update common/route vendoring for contextFn errors #2049

Merged
merged 1 commit into from
Oct 3, 2016
Merged

Conversation

juliusv
Copy link
Member

@juliusv juliusv commented Oct 2, 2016

@redbaron
Copy link
Contributor

redbaron commented Oct 2, 2016

just curious, why not submodules?

@juliusv
Copy link
Member Author

juliusv commented Oct 2, 2016

@redbaron In my experience, git submodules are even clunkier to use with weird behaviors, but the other reason is that Go vendoring tools don't use submodules either (at least none that I know of). Not sure if anyone uses submodules for Go vendoring purposes.

@redbaron
Copy link
Contributor

redbaron commented Oct 3, 2016

which go vendoring tools?

Vendor:

git submodule add  https://github.com/prometheus/common.git vendor/github.com/prometheus/common
( cd vendor/github.com/prometheus/common; git checkout <tag> )
git commit -a -m "Vendor prometheus/common"

Update:

( cd vendor/github.com/prometheus/common; git checkout <tag_to_update_to> )
git commit -a -m "Updated vendored prometheus/common"

anyway, whatever works best for you :)

@grobie
Copy link
Member

grobie commented Oct 3, 2016

Please let's not introduce submodules. I like them personally, but in my experience they'll cause a high support volume.

@grobie grobie merged commit f07e676 into master Oct 3, 2016
@juliusv
Copy link
Member Author

juliusv commented Oct 3, 2016

@redbaron Go vendoring tools also help you manage more than that, like automatically vendoring transitive dependencies. And they don't necessarily vendor the entire repo, but just the Go package directories you need, sometimes also without the test and other non-Go files.

@grobie grobie deleted the ctxfn-error branch November 3, 2016 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants