Fix missing roles in prometheus kubernetes example #1840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed with Prometheus 1.0
| @@ -60,6 +61,7 @@ scrape_configs: | |||
| - api_servers: | |||
| - 'https://kubernetes.default.svc' | |||
| in_cluster: true | |||
| role: endpoint | |||
|
|
|||
| relabel_configs: | |||
| - source_labels: [__meta_kubernetes_role, __meta_kubernetes_service_annotation_prometheus_io_scrape] | |||
There was a problem hiding this comment.
You can also drop the __meta_kubernetes_role in each of the source_labels.
There was a problem hiding this comment.
And the corresponding true; in the regexp.
There was a problem hiding this comment.
I see potential problem for the job kubernetes-cluster as there is a combination of two roles. If you set role to apiserver directly, you will not have entries for nodes targets.
There was a problem hiding this comment.
Good point - this needs a another job with role: node.
There was a problem hiding this comment.
Awesome, thanks. Will do.
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed with Prometheus 1.0