Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: push to Dockerhub and Quay #1580

Merged
merged 1 commit into from
Apr 24, 2016
Merged

build: push to Dockerhub and Quay #1580

merged 1 commit into from
Apr 24, 2016

Conversation

fabxc
Copy link
Contributor

@fabxc fabxc commented Apr 24, 2016

@sdurrheimer
Copy link
Contributor

You also need to duplicate the make dockerstep, if not, you're going to push nothing to quay.io.

    - |
      if [ -n "$CIRCLE_TAG" ]; then
        make docker DOCKER_IMAGE_NAME=$DOCKER_IMAGE_NAME DOCKER_IMAGE_TAG=$CIRCLE_TAG
        make docker DOCKER_IMAGE_NAME=$QUAY_IMAGE_NAME DOCKER_IMAGE_TAG=$CIRCLE_TAG
      else
        make docker DOCKER_IMAGE_NAME=$DOCKER_IMAGE_NAME
        make docker DOCKER_IMAGE_NAME=$QUAY_IMAGE_NAME
      fi

@fabxc
Copy link
Contributor Author

fabxc commented Apr 24, 2016

Done

@sdurrheimer
Copy link
Contributor

👍

@fabxc fabxc merged commit 490ff9f into master Apr 24, 2016
@fabxc fabxc deleted the fabxc/quay branch April 24, 2016 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fabxc @sdurrheimer