Add error message if old alert rule tokens are read #1561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -395,6 +405,12 @@ func (l *lexer) errorf(format string, args ...interface{}) stateFn { | |||
| func (l *lexer) nextItem() item { | |||
| item := <-l.items | |||
| l.lastPos = item.pos | |||
|
|
|||
| // TODO(fabxc): remove for version 1.0. | |||
There was a problem hiding this comment.
Could even be 0.19.0, or will that be the last 0. release \o/?
There was a problem hiding this comment.
I don't see us doing any large breaking changes that justify another 0.x and would like to go straight for 1.0 afterwards.
There was a problem hiding this comment.
#1503 will be a large breaking change that we should complete with 1.0.
There was a problem hiding this comment.
Yes, but that's essentially the last thing and doable within the scope of one minor (which will be the transition to 1.0). No reason for 0.19.
|
Awesome! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@grobie