Refactor and test appender modifications #1394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
fabxc
added a commit
that referenced
this pull request
Feb 15, 2016
Refactor and test appender modifications
| @@ -549,6 +563,38 @@ func (t *Target) scrape(appender storage.SampleAppender) error { | |||
| return err | |||
| } | |||
|
|
|||
| func (t *Target) report(app storage.SampleAppender, start time.Time, duration time.Duration, err error) { | |||
| t.status.setLastScrape(start) | |||
There was a problem hiding this comment.
Do you want to remove the other calls to setLastScrape() then? The ones in
prometheus/retrieval/target.go
Line 436 in 463dd3e
prometheus/retrieval/target.go
Line 456 in 463dd3e
There was a problem hiding this comment.
Totally right. Will fix that tomorrow.
And yea, recording scrapes that didn't happen actually skews the stats.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.