Rename global "labels" config option to "external_labels". #1129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| @@ -206,6 +206,10 @@ func reloadConfig(filename string, rls ...Reloadable) (success bool) { | |||
| conf, err := config.LoadFile(filename) | |||
| if err != nil { | |||
| log.Errorf("Couldn't load configuration (-config.file=%s): %v", filename, err) | |||
| // TODO(julius): Remove this notice when releasing 0.17.0 or 0.18.0. | |||
| if err.Error() == "unknown fields in global config: labels" { | |||
| log.Errorf("NOTE: The 'labels' setting in the global configuration section has been renamed to 'external_labels'. Please update your configuration file accordingly.") | |||
There was a problem hiding this comment.
I think it would be worth explaining that the semantics have changed as well and that external_labels don't get attached to time series anymore.
There was a problem hiding this comment.
Addressed that. I didn't link to the specific release in the CHANGELOG.md, as we are removing RC changelog entries after a final release and thus the link would break with 0.16.0.
juliusv
force-pushed
the
rename-global-labels
branch
from
ff4e665 to
61eb33f
Compare
juliusv
force-pushed
the
rename-global-labels
branch
from
61eb33f to
dac26ce
Compare
|
👍 |
1 similar comment
|
👍 |
juliusv
added a commit
that referenced
this pull request
Sep 30, 2015
Rename global "labels" config option to "external_labels".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.