Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop legacy API #1593

Closed
fabxc opened this issue Apr 25, 2016 · 12 comments
Closed

Drop legacy API #1593

fabxc opened this issue Apr 25, 2016 · 12 comments

Comments

@fabxc
Copy link
Contributor

fabxc commented Apr 25, 2016

No description provided.

@fabxc fabxc added this to the v1.0.0 milestone Apr 25, 2016
@juliusv
Copy link
Member

juliusv commented Apr 25, 2016

Just double-checked: PromDash does still use the legacy API, unfortunately :(

So we can fix PromDash, keep the legacy API, or remove it and say it's ok to break PromDash (probably not so nice)...

@fabxc
Copy link
Contributor Author

fabxc commented Apr 27, 2016

Upgrading PromDash should be straightforward – mostly prefixing v1/.
Any Ruby volunteers?

@stuartnelson3 @grobie :)

@stuartnelson3
Copy link
Contributor

Can one of you point me to an updated API doc? I'll do this ASAP and open a PR for your verification.

@fabxc
Copy link
Contributor Author

fabxc commented Apr 27, 2016

Great!

The API v1 docs are here.

@juliusv
Copy link
Member

juliusv commented Apr 27, 2016

Note that the URL change is the least part - the request/response has completely changed. But you should be able to copy the relevant bits from the Prometheus server's JS.

@stuartnelson3
Copy link
Contributor

Who was the lazy person that updated the prometheus JS but not promdash..

@fabxc
Copy link
Contributor Author

fabxc commented Jun 23, 2016

So we can drop it? @stuartnelson3

@stuartnelson3
Copy link
Contributor

Hey sitting in HBF, but promdash has been using the new API for a while. It
should be fine, but I haven't confirmed.

Am Donnerstag, 23. Juni 2016 schrieb Fabian Reinartz :

So we can drop it? @stuartnelson3 https://github.com/stuartnelson3


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#1593 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABVVWP3KnkG7Ik-wcfw8ZlRzXvfbjeLsks5qOqH5gaJpZM4IPJVJ
.

@juliusv
Copy link
Member

juliusv commented Jun 23, 2016

Confirmed: prometheus-junkyard/promdash#484

Old API begone!

@beorn7
Copy link
Member

beorn7 commented Jun 23, 2016

See comment on #1761 and see the PR #1601

@fabxc
Copy link
Contributor Author

fabxc commented Jun 24, 2016

Saw the PR – just wanted to be sure.
Seems we don't have versioned PromDash releases so it's fixed as soon as
it's in master?

On Thu, Jun 23, 2016 at 10:46 PM Björn Rabenstein notifications@github.com
wrote:

See comment on #1761 #1761
and see the PR #1601 #1601


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#1593 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AEuA8o66BWngc62hY8ZmpOEmKM_K_DCmks5qOvCJgaJpZM4IPJVJ
.

@lock
Copy link

lock bot commented Mar 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants