-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop legacy API #1593
Comments
Just double-checked: PromDash does still use the legacy API, unfortunately :( So we can fix PromDash, keep the legacy API, or remove it and say it's ok to break PromDash (probably not so nice)... |
Upgrading PromDash should be straightforward – mostly prefixing |
Can one of you point me to an updated API doc? I'll do this ASAP and open a PR for your verification. |
Great! The API v1 docs are here. |
Note that the URL change is the least part - the request/response has completely changed. But you should be able to copy the relevant bits from the Prometheus server's JS. |
Who was the lazy person that updated the prometheus JS but not promdash.. |
So we can drop it? @stuartnelson3 |
Hey sitting in HBF, but promdash has been using the new API for a while. It Am Donnerstag, 23. Juni 2016 schrieb Fabian Reinartz :
|
Confirmed: prometheus-junkyard/promdash#484 Old API begone! |
Saw the PR – just wanted to be sure. On Thu, Jun 23, 2016 at 10:46 PM Björn Rabenstein notifications@github.com
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
No description provided.
The text was updated successfully, but these errors were encountered: