Flatten the buckets of native histograms #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is slightly more efficient on the wire, and it matches the way the corresponding Go types are structured (`histogram.Histogram` and `histogram.FloatHistogram`). This follow the change for the remote-write protobuf in prometheus/prometheus#11011 . This commit also moves away from the "sparse histogram" naming in lieu of the preferred name "native histogram". Note that this is deliberately an incompatible change of the proto spec. Keeping compatibility would cause some hassle but not much gain because we haven't published the proto spec in any release yet and always marked it as experimental. Compatibility to the released proto spec (without native histograms) is kept, of course. Signed-off-by: beorn7 <beorn@grafana.com>
LeviHarrison
approved these changes
Jul 15, 2022
codesome
approved these changes
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is only for the sparsehistogram branch.
This is slightly more efficient on the wire, and it matches the way
the corresponding Go types are structured (
histogram.Histogramandhistogram.FloatHistogram). This follow the change for theremote-write protobuf in
prometheus/prometheus#11011 .
This commit also moves away from the "sparse histogram" naming in lieu
of the preferred name "native histogram".
Note that this is deliberately an incompatible change of the proto
spec. Keeping compatibility would cause some hassle but not much gain
because we haven't published the proto spec in any release yet and
always marked it as experimental. Compatibility to the released proto
spec (without native histograms) is kept, of course.
Signed-off-by: beorn7 beorn@grafana.com