Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: prometheus/client_golang
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.20.2
Choose a base ref
...
head repository: prometheus/client_golang
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.20.3
Choose a head ref
  • 8 commits
  • 3 files changed
  • 3 contributors

Commits on Sep 4, 2024

  1. native histogram: use exemplars in concurrency test 

    Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
    @krajorama
    krajorama committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    e061dfa View commit details
    Browse the repository at this point in the history

  2. Use a trivial solution to #1605 

    Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
    @krajorama
    krajorama committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    dc819ce View commit details
    Browse the repository at this point in the history

  3. fix: native histogram: Simplify and fix addExemplar 

    mdIdx was redundant when len(exemplars)>1, so got rid of it, rIdx
is enough.

Don't compare timestamp of incoming exemplar to timestamp of
minimal distance exemplar. Most of the time the incoming exemplar
will be newer. And if not, the previous code just replaced an
exemplar one index after the minimal distance exemplar. Which had
an index out of range bug, plus is essentially random.

Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
    @krajorama
    krajorama committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    dc8e9a4 View commit details
    Browse the repository at this point in the history

  4. Use simplified solution from #1609 for the data race 

    Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
    @krajorama
    krajorama committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    504566f View commit details
    Browse the repository at this point in the history

  5. Update comments with more explanations 

    Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
    @krajorama
    krajorama committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    d6b8c89 View commit details
    Browse the repository at this point in the history

  6. Merge pull request #1608 from krajorama/index-out-of-range-native-his… 

    …togram-exemplar

bugfix: native histogram: exemplars index out of range
    @krajorama
    krajorama authored Sep 4, 2024
    Configuration menu
    Copy the full SHA
    6e9914d View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. Add changelog entry for 1.20.3 

    Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
    @ArthurSens
    ArthurSens committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    937ac63 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #1620 from prometheus/arthursens/prepare-1.20.3 

    Add changelog entry for 1.20.3
    @ArthurSens
    ArthurSens authored Sep 5, 2024
    Configuration menu
    Copy the full SHA
    ef2f87e View commit details
    Browse the repository at this point in the history
Loading