Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add projen contributing guide #482

Merged
merged 2 commits into from
Jan 14, 2021

Conversation

Chriscbr
Copy link
Contributor


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Chriscbr Chriscbr requested a review from eladb January 13, 2021 05:16
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add link to this in the README?

@codecov-io
Copy link

Codecov Report

Merging #482 (881c2ca) into master (39b2dbe) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #482      +/-   ##
==========================================
- Coverage   75.99%   75.95%   -0.04%     
==========================================
  Files          75       75              
  Lines        2683     2683              
  Branches      697      618      -79     
==========================================
- Hits         2039     2038       -1     
- Misses        641      644       +3     
+ Partials        3        1       -2     
Impacted Files Coverage Δ
src/ignore-file.ts 100.00% <100.00%> (ø)
src/json.ts 93.33% <100.00%> (ø)
src/cleanup.ts 88.46% <0.00%> (-7.70%) ⬇️
src/node-package.ts 63.85% <0.00%> (ø)
src/tasks/runtime.ts 16.30% <0.00%> (ø)
src/util.ts 86.74% <0.00%> (+1.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7562663...881c2ca. Read the comment docs.

@mergify mergify bot merged commit 10b91b0 into projen:master Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants