feat(java): projenrc.java #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 7, 2021 14:01
If `projenrc` is set to `true` for java projects, a `synth` task will be added which will execute the Java program under `src/test/java/projenrc.java`. This enables writing your projenrc files in java (for java projects). Enabling this will add a test dependency on `com.github.eladb/projen` and a task called `synth` which will compile the code and run it. So your workflow is to update `projenrc.java` and run `pj synth`. In a subsequent commit, we will auto-detect the `synth` task and use it when `pj` is executed without any subcommand, so projects can customize their synthesize task.
hoegertn
reviewed
Jan 7, 2021
| execute this program. | ||
|
|
||
| By default, `projenrc.java` is placed under the `test` scope (and | ||
| `com.github.eladb/projen` test dependency is added). This ensures that |
There was a problem hiding this comment.
Above it says org.projen/projen
There was a problem hiding this comment.
The group id is com.github.eladb but the java package is org.projen. I was just lazy to create a new group ID for projen at the moment, but we can do that later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
projenrcJavais set totruefor java projects (or--projenrc-javaswitch is provided inprojen new, the java project will support writing your projenrc file in java (yeah!).In this case, the projenrc file will be located under
src/test/java/projenrc.javaandprojen synthwill take care to compile it and execute it with a dependency oncom.github.eladb/projen.Next steps:
synthtask and defer to it whenpjis executed without a subcommand. This will allow projects to customize how synth is performed for each language.projen newwill still generate a.projenrc.jsfile, but this should be moved from the CLI to the library and thenjava.Projenrcshould generate the Java equivalent in the right location when the project is bootstrapped. That should be fun.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.