Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node-project): code artifact login command #1798

Merged
merged 2 commits into from
Apr 26, 2022

Conversation

AminFazlMondo
Copy link
Contributor

@AminFazlMondo AminFazlMondo commented Apr 26, 2022

Added validation to include trailing slash in the registryUrl

Fixed ca:login task by:

  • Removed repository parameter from aws call
  • Removed https:// from registryUrl used in npm config

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Chriscbr Chriscbr changed the title fix(node-project): Fixed code artifact login command fix(node-project): code artifact login command Apr 26, 2022
@mergify mergify bot merged commit cb14a1b into projen:main Apr 26, 2022
@AminFazlMondo AminFazlMondo deleted the fix/ScopedPackages branch April 26, 2022 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants