Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate node v12 support #1795

Merged
merged 2 commits into from
Apr 25, 2022
Merged

chore: deprecate node v12 support #1795

merged 2 commits into from
Apr 25, 2022

Conversation

Chriscbr
Copy link
Contributor

Node v12 reaches end of life on April 30, 2022. This PR adds a warning that projen will be dropping support for old node releases.

We'll give this message a week to incubate before actually bumping the version we support (#1768).


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Chriscbr Chriscbr requested review from kaizencc and a team April 25, 2022 17:53
@mergify mergify bot added the contribution/core ⚙️ used by automation label Apr 25, 2022
Signed-off-by: github-actions <github-actions@github.com>
@codecov-commenter
Copy link

Codecov Report

Merging #1795 (15f29e1) into main (d90284c) will increase coverage by 1.82%.
The diff coverage is 91.49%.

@@            Coverage Diff             @@
##             main    #1795      +/-   ##
==========================================
+ Coverage   88.06%   89.88%   +1.82%     
==========================================
  Files         132      153      +21     
  Lines        5109     6249    +1140     
  Branches     1207     1602     +395     
==========================================
+ Hits         4499     5617    +1118     
- Misses        610      627      +17     
- Partials        0        5       +5     
Impacted Files Coverage Δ
src/cdk/consts.ts 100.00% <ø> (+36.36%) ⬆️
src/dev-env.ts 83.33% <0.00%> (ø)
src/java/index.ts 100.00% <ø> (ø)
src/python/index.ts 100.00% <ø> (ø)
src/release/bump-version.ts 98.68% <ø> (+0.05%) ⬆️
src/release/index.ts 100.00% <ø> (ø)
src/release/publisher.ts 98.85% <ø> (-0.38%) ⬇️
src/release/release-trigger.ts 100.00% <ø> (ø)
src/release/release.ts 95.79% <ø> (-2.06%) ⬇️
src/release/tag-version.ts 86.66% <ø> (ø)
... and 185 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c50270c...15f29e1. Read the comment docs.

@mergify mergify bot merged commit 6db1b04 into main Apr 25, 2022
@mergify mergify bot deleted the rybickic/node-version-check branch April 25, 2022 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core ⚙️ used by automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants