Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(javascript): upgrade worflow fails when using pnpm #1794

Merged
merged 2 commits into from
Apr 25, 2022

Conversation

skyrpex
Copy link
Contributor

@skyrpex skyrpex commented Apr 25, 2022

Fixes #1704


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2022

Codecov Report

Merging #1794 (dae7659) into main (d90284c) will increase coverage by 1.88%.
The diff coverage is 91.49%.

@@            Coverage Diff             @@
##             main    #1794      +/-   ##
==========================================
+ Coverage   88.06%   89.94%   +1.88%     
==========================================
  Files         132      153      +21     
  Lines        5109     6243    +1134     
  Branches     1207     1601     +394     
==========================================
+ Hits         4499     5615    +1116     
- Misses        610      623      +13     
- Partials        0        5       +5     
Impacted Files Coverage Δ
src/cdk/consts.ts 100.00% <ø> (+36.36%) ⬆️
src/dev-env.ts 83.33% <0.00%> (ø)
src/java/index.ts 100.00% <ø> (ø)
src/python/index.ts 100.00% <ø> (ø)
src/release/bump-version.ts 98.68% <ø> (+0.05%) ⬆️
src/release/index.ts 100.00% <ø> (ø)
src/release/publisher.ts 98.85% <ø> (-0.38%) ⬇️
src/release/release-trigger.ts 100.00% <ø> (ø)
src/release/release.ts 95.79% <ø> (-2.06%) ⬇️
src/release/tag-version.ts 86.66% <ø> (ø)
... and 185 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c790f9...dae7659. Read the comment docs.

@mergify mergify bot merged commit c50270c into projen:main Apr 25, 2022
@skyrpex skyrpex deleted the skyrpex/fix-pnpm-upgrade-workflow branch April 25, 2022 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pnpm lockfile error after changing project package manager to pnpm
3 participants