Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: suppress cdk template using -q instead of /dev/null (#1780) #1781

Merged

Conversation

marnixdessing
Copy link
Contributor

Fixes #1780


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

Codecov Report

Merging #1781 (e650429) into main (d90284c) will increase coverage by 1.88%.
The diff coverage is 91.53%.

@@            Coverage Diff             @@
##             main    #1781      +/-   ##
==========================================
+ Coverage   88.06%   89.94%   +1.88%     
==========================================
  Files         132      153      +21     
  Lines        5109     6233    +1124     
  Branches     1207     1595     +388     
==========================================
+ Hits         4499     5606    +1107     
- Misses        610      622      +12     
- Partials        0        5       +5     
Impacted Files Coverage Δ
src/cdk/consts.ts 100.00% <ø> (+36.36%) ⬆️
src/dev-env.ts 83.33% <0.00%> (ø)
src/java/index.ts 100.00% <ø> (ø)
src/python/index.ts 100.00% <ø> (ø)
src/release/bump-version.ts 98.68% <ø> (+0.05%) ⬆️
src/release/index.ts 100.00% <ø> (ø)
src/release/publisher.ts 98.85% <ø> (-0.38%) ⬇️
src/release/release-trigger.ts 100.00% <ø> (ø)
src/release/release.ts 95.79% <ø> (-2.06%) ⬇️
src/release/tag-version.ts 86.66% <ø> (ø)
... and 184 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bff6362...e650429. Read the comment docs.

Copy link
Contributor

@Chriscbr Chriscbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, good catch @marnixdessing ! Thanks for submitting this PR 🙂

@mergify mergify bot merged commit d11fb80 into projen:main Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use quiet option in cdk synth:silent
3 participants