fix: cannot use file path dependencies #1779
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1779 +/- ##
==========================================
+ Coverage 88.06% 89.91% +1.85%
==========================================
Files 132 153 +21
Lines 5109 6238 +1129
Branches 1207 1596 +389
==========================================
+ Hits 4499 5609 +1110
- Misses 610 624 +14
- Partials 0 5 +5
Continue to review full report at Codecov.
|
Signed-off-by: github-actions <github-actions@github.com>
|
👍 |
src/javascript/node-package.ts
Outdated
| if (semver.validRange(version)) { | ||
| return semver.minVersion(version)?.version; | ||
| } else { | ||
| return version; |
There was a problem hiding this comment.
question: what about when someone erroneously supplies an invalid semver version. We don't error out, and maybe they would expect that. Can we attach a warning or something to this? I'm guessing Annotations don't exist in projen, so might be wishful thinking.
There was a problem hiding this comment.
If the semver version is invalid, it will be caught when yarn install or npm install fails.
Signed-off-by: github-actions <github-actions@github.com>
Fixes #1777
We've supported dependency versions that aren't strictly semver-strings for a while now (see for example: #527). This simply makes the logic a little more robust / less prone to causing sudden errors.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license