Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nextjs-ts): silences incremental warning with typescript #1775

Merged
merged 6 commits into from
Apr 18, 2022
Merged

fix(nextjs-ts): silences incremental warning with typescript #1775

merged 6 commits into from
Apr 18, 2022

Conversation

pgollucci
Copy link
Contributor

@pgollucci pgollucci commented Apr 18, 2022

```
The following suggested values were added to your tsconfig.json. These values can be changed to fit your project's needs:
        - incremental was set to true
```

The above should be gone now.

pgollucci and others added 5 commits April 15, 2022 20:20
Upgrades project dependencies. See details in [workflow run].

[Workflow Run]: https://github.com/projen/projen/actions/runs/2174970792

------

*Automatically created by projen via the "upgrade-main" workflow*
Upgrades project dependencies. See details in [workflow run].

[Workflow Run]: https://github.com/projen/projen/actions/runs/2178352139

------

*Automatically created by projen via the "upgrade-main" workflow*
Upgrades project dependencies. See details in [workflow run].

[Workflow Run]: https://github.com/projen/projen/actions/runs/2181562410

------

*Automatically created by projen via the "upgrade-main" workflow*
```
The following suggested values were added to your tsconfig.json. These values can be changed to fit your project's needs:
        - incremental was set to true
```

The above should be gone now.
@pgollucci pgollucci changed the title fix/nextjs ts incremental#pdf ouadyf fix(fix/nextjs): silences gl Apr 18, 2022
@pgollucci pgollucci changed the title fix(fix/nextjs): silences gl fix(fix/nextjs): silences incremental warning with typescriptd Apr 18, 2022
@pgollucci pgollucci changed the title fix(fix/nextjs): silences incremental warning with typescriptd fix(fix/nextjs): silences incremental warning with typescript Apr 18, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2022

Codecov Report

Merging #1775 (2057e96) into main (d90284c) will increase coverage by 1.88%.
The diff coverage is 91.53%.

@@            Coverage Diff             @@
##             main    #1775      +/-   ##
==========================================
+ Coverage   88.06%   89.94%   +1.88%     
==========================================
  Files         132      153      +21     
  Lines        5109     6233    +1124     
  Branches     1207     1595     +388     
==========================================
+ Hits         4499     5606    +1107     
- Misses        610      622      +12     
- Partials        0        5       +5     
Impacted Files Coverage Δ
src/cdk/consts.ts 100.00% <ø> (+36.36%) ⬆️
src/dev-env.ts 83.33% <0.00%> (ø)
src/java/index.ts 100.00% <ø> (ø)
src/python/index.ts 100.00% <ø> (ø)
src/release/bump-version.ts 98.68% <ø> (+0.05%) ⬆️
src/release/index.ts 100.00% <ø> (ø)
src/release/publisher.ts 98.85% <ø> (-0.38%) ⬇️
src/release/release-trigger.ts 100.00% <ø> (ø)
src/release/release.ts 95.79% <ø> (-2.06%) ⬇️
src/release/tag-version.ts 86.66% <ø> (ø)
... and 184 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 795c996...2057e96. Read the comment docs.

@pgollucci pgollucci changed the title fix(fix/nextjs): silences incremental warning with typescript fix(nextjs-ts): silences incremental warning with typescript Apr 18, 2022
@mergify mergify bot merged commit 7aaa602 into projen:main Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants