-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(nextjs-ts): silences incremental
warning with typescript
#1775
Merged
mergify
merged 6 commits into
projen:main
from
pgollucci:fix/nextjs-ts-incremental#pdf-ouadyf
Apr 18, 2022
Merged
fix(nextjs-ts): silences incremental
warning with typescript
#1775
mergify
merged 6 commits into
projen:main
from
pgollucci:fix/nextjs-ts-incremental#pdf-ouadyf
Apr 18, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pgollucci
commented
Apr 18, 2022
•
edited
Loading
edited
Upgrades project dependencies. See details in [workflow run]. [Workflow Run]: https://github.com/projen/projen/actions/runs/2174970792 ------ *Automatically created by projen via the "upgrade-main" workflow*
Upgrades project dependencies. See details in [workflow run]. [Workflow Run]: https://github.com/projen/projen/actions/runs/2178352139 ------ *Automatically created by projen via the "upgrade-main" workflow*
Upgrades project dependencies. See details in [workflow run]. [Workflow Run]: https://github.com/projen/projen/actions/runs/2181562410 ------ *Automatically created by projen via the "upgrade-main" workflow*
``` The following suggested values were added to your tsconfig.json. These values can be changed to fit your project's needs: - incremental was set to true ``` The above should be gone now.
pgollucci
changed the title
fix/nextjs ts incremental#pdf ouadyf
fix(fix/nextjs): silences gl
Apr 18, 2022
pgollucci
changed the title
fix(fix/nextjs): silences gl
fix(fix/nextjs): silences Apr 18, 2022
incremental
warning with typescriptd
pgollucci
changed the title
fix(fix/nextjs): silences
fix(fix/nextjs): silences Apr 18, 2022
incremental
warning with typescriptdincremental
warning with typescript
Codecov Report
@@ Coverage Diff @@
## main #1775 +/- ##
==========================================
+ Coverage 88.06% 89.94% +1.88%
==========================================
Files 132 153 +21
Lines 5109 6233 +1124
Branches 1207 1595 +388
==========================================
+ Hits 4499 5606 +1107
- Misses 610 622 +12
- Partials 0 5 +5
Continue to review full report at Codecov.
|
pgollucci
changed the title
fix(fix/nextjs): silences
fix(nextjs-ts): silences Apr 18, 2022
incremental
warning with typescriptincremental
warning with typescript
Chriscbr
approved these changes
Apr 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.