Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nextjs-ts): starter project fails to build with projenrc.ts #1769

Merged
merged 1 commit into from
Apr 15, 2022
Merged

fix(nextjs-ts): starter project fails to build with projenrc.ts #1769

merged 1 commit into from
Apr 15, 2022

Conversation

pgollucci
Copy link
Contributor

@pgollucci pgollucci commented Apr 14, 2022

fixes #1463

@pgollucci
Copy link
Contributor Author

pgollucci commented Apr 14, 2022

There are other downstream issues like eslint, incremental, js vs json, and too much stuff being in or out of rootDir or pages.

@codecov-commenter
Copy link

Codecov Report

Merging #1769 (88ad12e) into main (d90284c) will increase coverage by 1.88%.
The diff coverage is 91.53%.

@@            Coverage Diff             @@
##             main    #1769      +/-   ##
==========================================
+ Coverage   88.06%   89.94%   +1.88%     
==========================================
  Files         132      153      +21     
  Lines        5109     6233    +1124     
  Branches     1207     1595     +388     
==========================================
+ Hits         4499     5606    +1107     
- Misses        610      622      +12     
- Partials        0        5       +5     
Impacted Files Coverage Δ
src/cdk/consts.ts 100.00% <ø> (+36.36%) ⬆️
src/dev-env.ts 83.33% <0.00%> (ø)
src/java/index.ts 100.00% <ø> (ø)
src/python/index.ts 100.00% <ø> (ø)
src/release/bump-version.ts 98.68% <ø> (+0.05%) ⬆️
src/release/index.ts 100.00% <ø> (ø)
src/release/publisher.ts 98.85% <ø> (-0.38%) ⬇️
src/release/release-trigger.ts 100.00% <ø> (ø)
src/release/release.ts 95.79% <ø> (-2.06%) ⬇️
src/release/tag-version.ts 86.66% <ø> (ø)
... and 184 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fac7ae...88ad12e. Read the comment docs.

@Chriscbr
Copy link
Contributor

I'm not sure if this fixes the linked issue. This comment says that we need to change tsconfig.dev.json, not tsconfig.json.

@pgollucci
Copy link
Contributor Author

@Chriscbr actually it does. It does both. Look at the diff of the snap test. You'll need to click on the view file to see the scopes.

@pgollucci
Copy link
Contributor Author

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented Apr 15, 2022

rebase

✅ Branch has been successfully rebased

@Chriscbr Chriscbr changed the title fix(nextjs-ts): fixes #1463 adds test fix(nextjs-ts): starter project fails to build with projenrc.ts Apr 15, 2022
Copy link
Contributor

@Chriscbr Chriscbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pgollucci Ah, I'm duly mistaken. Thanks for the fix!

@mergify mergify bot merged commit af04922 into projen:main Apr 15, 2022
@doyasu24
Copy link

The same error occurs when the following commands

I tried these commands again and confirmed that the issue was fixed.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

react-ts: Warning: To load an ES module, set "type": "module" in the package.json or use the .mjs extension
4 participants