-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(nextjs-ts): starter project fails to build with projenrc.ts #1769
Conversation
There are other downstream issues like |
Codecov Report
@@ Coverage Diff @@
## main #1769 +/- ##
==========================================
+ Coverage 88.06% 89.94% +1.88%
==========================================
Files 132 153 +21
Lines 5109 6233 +1124
Branches 1207 1595 +388
==========================================
+ Hits 4499 5606 +1107
- Misses 610 622 +12
- Partials 0 5 +5
Continue to review full report at Codecov.
|
I'm not sure if this fixes the linked issue. This comment says that we need to change tsconfig.dev.json, not tsconfig.json. |
@Chriscbr actually it does. It does both. Look at the diff of the snap test. You'll need to click on the view file to see the scopes. |
@Mergifyio rebase |
✅ Branch has been successfully rebased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pgollucci Ah, I'm duly mistaken. Thanks for the fix!
I tried these commands again and confirmed that the issue was fixed. |
fixes #1463