Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(publisher): match first changelog entry #1750

Conversation

gradybarrett
Copy link
Contributor

@gradybarrett gradybarrett commented Apr 9, 2022

The first ever changelog entry created by standard-version
doesn't link to a diff because none exists yet. For that
reason there are no markdown link brackets around the
version, which was causing the first manual release to
fail.

Closes #1749


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Apr 9, 2022

Codecov Report

Merging #1750 (96a77f8) into main (d90284c) will increase coverage by 1.83%.
The diff coverage is 91.62%.

@@            Coverage Diff             @@
##             main    #1750      +/-   ##
==========================================
+ Coverage   88.06%   89.89%   +1.83%     
==========================================
  Files         132      152      +20     
  Lines        5109     6177    +1068     
  Branches     1207     1575     +368     
==========================================
+ Hits         4499     5553    +1054     
- Misses        610      619       +9     
- Partials        0        5       +5     
Impacted Files Coverage Δ
src/cdk/consts.ts 100.00% <ø> (+36.36%) ⬆️
src/dev-env.ts 83.33% <0.00%> (ø)
src/java/index.ts 100.00% <ø> (ø)
src/python/index.ts 100.00% <ø> (ø)
src/release/index.ts 100.00% <ø> (ø)
src/release/publisher.ts 98.85% <ø> (-0.39%) ⬇️
src/release/release-trigger.ts 100.00% <ø> (ø)
src/release/release.ts 95.76% <ø> (-2.09%) ⬇️
src/release/tag-version.ts 86.66% <ø> (ø)
src/release/update-changelog.ts 100.00% <ø> (ø)
... and 184 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ce4ee5...96a77f8. Read the comment docs.

@gradybarrett gradybarrett force-pushed the gradybarrett/fix-manual-release-version-matching branch from 5810e36 to 96a77f8 Compare April 9, 2022 18:39
The first changelog entry created by standard-version
doesn't link to a diff because none exists yet. For that
reason, there are no markdown link brackets around the
version, which causes the first manual release to
fail. Removing the brackets and just matching the version
to fix this issue.

Closes projen#1749
@gradybarrett gradybarrett force-pushed the gradybarrett/fix-manual-release-version-matching branch from 96a77f8 to 7aef9c8 Compare April 11, 2022 17:57
@mergify mergify bot merged commit 09cf63e into projen:main Apr 11, 2022
@gradybarrett gradybarrett deleted the gradybarrett/fix-manual-release-version-matching branch April 11, 2022 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(release): manual releases don't match the first release changelog entry
3 participants