fix: Add support for upper case variables #1721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chriscbr
suggested changes
Apr 5, 2022
This was referenced Apr 6, 2022
mergify bot
pushed a commit
that referenced
this pull request
Apr 6, 2022
Currently new projen development builds are failing (example: #1721) because `yaml` published v2.0.0 to the `next` tag, in which they bumped the minimum node version they require from 12 to 14. Since new development builds are automatically picking this up and projen still supports node v12, this PR pins the version of `yaml` so the new version isn't picked up by `yarn install`. This should fix #1740 We should also upgrade the minimum node version projen supports, but it's better to do that in a separate PR. (Issue: #1739) --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Chriscbr
approved these changes
Apr 6, 2022
Codecov Report
@@ Coverage Diff @@
## main #1721 +/- ##
==========================================
+ Coverage 88.06% 89.89% +1.83%
==========================================
Files 132 152 +20
Lines 5109 6177 +1068
Branches 1207 1692 +485
==========================================
+ Hits 4499 5553 +1054
- Misses 610 619 +9
- Partials 0 5 +5
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the issue of job variables rendering as snake case and don't respecting the original format
closes #1693
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.