Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(awscdk-app): initialize sample code stack names based on project name #1711

Merged
merged 6 commits into from
Mar 24, 2022

Conversation

marciocadev
Copy link
Contributor

@marciocadev marciocadev commented Mar 24, 2022

closes #1708


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Mar 24, 2022

Codecov Report

Merging #1711 (434405a) into main (d90284c) will increase coverage by 1.56%.
The diff coverage is 91.06%.

@@            Coverage Diff             @@
##             main    #1711      +/-   ##
==========================================
+ Coverage   88.06%   89.62%   +1.56%     
==========================================
  Files         132      151      +19     
  Lines        5109     6158    +1049     
  Branches     1207     1583     +376     
==========================================
+ Hits         4499     5519    +1020     
- Misses        610      637      +27     
- Partials        0        2       +2     
Impacted Files Coverage Δ
src/cdk/consts.ts 100.00% <ø> (+36.36%) ⬆️
src/dev-env.ts 83.33% <0.00%> (ø)
src/java/index.ts 100.00% <ø> (ø)
src/python/index.ts 100.00% <ø> (ø)
src/release/index.ts 100.00% <ø> (ø)
src/release/release.ts 97.22% <ø> (-0.63%) ⬇️
src/release/tag-version.ts 86.66% <ø> (ø)
src/release/update-changelog.ts 100.00% <ø> (ø)
src/sample-file.ts 93.75% <ø> (+0.13%) ⬆️
src/semver.ts 20.00% <ø> (ø)
... and 183 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36ed7dd...434405a. Read the comment docs.

Copy link
Contributor

@Chriscbr Chriscbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one small change

@Chriscbr Chriscbr changed the title feat(awscdk-app): Changing static stackId to variable according to project name and turning the app.py writable feat(awscdk-app): initialize sample code stack names based on project name Mar 24, 2022
src/awscdk/awscdk-app-py.ts Outdated Show resolved Hide resolved
@mergify mergify bot merged commit 3605687 into projen:main Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(awscdk) Use project name as stackId instead of an hardcode my-stack-dev and my-stack-prod
3 participants