feat!: GitHub API access via GitHub Apps in workflows #1709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: github-actions <github-actions@github.com>
Codecov Report
@@ Coverage Diff @@
## main #1709 +/- ##
==========================================
+ Coverage 88.06% 89.50% +1.44%
==========================================
Files 132 152 +20
Lines 5109 6177 +1068
Branches 1207 1575 +368
==========================================
+ Hits 4499 5529 +1030
- Misses 610 646 +36
- Partials 0 2 +2
Continue to review full report at Codecov.
|
Chriscbr
changed the title
RomainMuller
approved these changes
Mar 29, 2022
kaizencc
pushed a commit
that referenced
this pull request
Apr 4, 2022
Fixes #1657 Allows projen workflows requiring GitHub API access beyond the permissions of GITHUB_TOKEN to specify access from either a personal access token or a GitHub App. It can be configured like so: ```ts const { javascript, github } = require('projen'); const project = new javascript.NodeProject({ // ...other options githubOptions: { projenCredentials: github.GithubCredentials.fromApp({ ... }), }, }); ``` See https://github.com/projen/projen/blob/rybickic/github-app-access/docs/github.md for more details. This change also removes `projenUpgradeSecret` from NodeProjectOptions, which resulted in a cascade of other breaking changes. Since #1383 (v0.47.0) we've required provide a PROJEN_GITHUB_TOKEN for all projects, but NodeProject still assumed projects were using GITHUB_TOKEN by default, so projects were being created with separate workflows for upgrading projen and for upgrading other dependencies. I've removed that default, though it's still possible to create these kinds of workflows separately (details here: https://github.com/projen/projen/blob/rybickic/github-app-access/docs/node.md). BREAKING CHANGE: The deprecated `projenUpgradeSecret` is removed, and GitHub API access is now customizable through `githubOptions.projenCredentials`. * Separate tasks/workflows for upgrading projen (and approving those PRs) are no longer generated by default. `autoApproveProjenUpgrades`, `projenUpgradeAutoMerge`, and `projenUpgradeSchedule`have been correspondingly removed. --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1657
Allows projen workflows requiring GitHub API access beyond the permissions of GITHUB_TOKEN to specify access from either a personal access token or a GitHub App. It can be configured like so:
See https://github.com/projen/projen/blob/rybickic/github-app-access/docs/github.md for more details.
This change also removes
projenUpgradeSecretfrom NodeProjectOptions, which resulted in a cascade of other breaking changes. Since #1383 (v0.47.0) we've required provide a PROJEN_GITHUB_TOKEN for all projects, but NodeProject still assumed projects were using GITHUB_TOKEN by default, so projects were being created with separate workflows for upgrading projen and for upgrading other dependencies. I've removed that default, though it's still possible to create these kinds of workflows separately (details here: https://github.com/projen/projen/blob/rybickic/github-app-access/docs/node.md).BREAKING CHANGE: The deprecated
projenUpgradeSecretis removed, and GitHub API access is now customizable throughgithubOptions.projenCredentials.autoApproveProjenUpgrades,projenUpgradeAutoMerge, andprojenUpgradeSchedulehave been correspondingly removed.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.