fix: upgrade deps and improve upgrade task resiliency #1698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: github-actions <github-actions@github.com>
otaviomacedo
approved these changes
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current upgrade workflow is failing because a previous upgrade updated us to using a buggy version of a transitive dependency (
lru-cache@7.7.0), which is being used by the verynpm-check-updatespackage we are using in the workflow. The bug was fixed inlru-cache@7.7.1, but since the workflow is using the bugged version, we can't pick up the dependency automatically. So to fix it workflow, we need to manually upgrade the outdated version ofnpm-check-updates.To prevent this failure in the future, I've updated the
upgradetask to try to upgrade npm-check-updates before everything else. Not strictly necessary, but it should eliminate this kind of (rare) failure mode.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license