feat: set assignees for dependency upgrade PRs #1692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1692 +/- ##
==========================================
+ Coverage 88.06% 89.62% +1.56%
==========================================
Files 132 151 +19
Lines 5109 6157 +1048
Branches 1207 1582 +375
==========================================
+ Hits 4499 5518 +1019
- Misses 610 637 +27
- Partials 0 2 +2
Continue to review full report at Codecov.
|
Signed-off-by: github-actions <github-actions@github.com>
kaizencc
approved these changes
Mar 17, 2022
| @@ -367,6 +367,8 @@ export class UpgradeDependencies extends Component { | |||
| branch: branchName, | |||
| title: title, | |||
| labels: this.options.workflowOptions?.labels?.join(",") || undefined, | |||
| assignees: | |||
| this.options.workflowOptions?.assignees?.join(",") || undefined, | |||
There was a problem hiding this comment.
Just calling out that I found it odd that we were using || here but I guess that is because [].join(",") === "" and we want that to be undefined also. If there's more to it let me know, cuz it seems like we gravitate towards ?? more.
There was a problem hiding this comment.
Yeah I believe it's to handle the empty array case, but you're right we usually prefer ??
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the documentation of https://github.com/marketplace/actions/create-pull-request
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.