fix: jsii-pacmak is not included as dev dependency #1686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1686 +/- ##
==========================================
+ Coverage 88.06% 89.61% +1.55%
==========================================
Files 132 151 +19
Lines 5109 6153 +1044
Branches 1207 1579 +372
==========================================
+ Hits 4499 5514 +1015
- Misses 610 637 +27
- Partials 0 2 +2
Continue to review full report at Codecov.
|
kaizencc
approved these changes
Mar 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes while doing a local build, I encounter the build hanging because the relevant version of jsii-pacmak hasn't been installed:
Instead let's just add it as a dev dependency outright.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.