-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(awscdk-app-py): adding support for building CDK apps with python #1579
Conversation
…-sample class, that way I can do specific tests when I create a python cdk app
Codecov Report
@@ Coverage Diff @@
## main #1579 +/- ##
==========================================
+ Coverage 88.06% 89.48% +1.42%
==========================================
Files 132 150 +18
Lines 5109 6051 +942
Branches 1207 1552 +345
==========================================
+ Hits 4499 5415 +916
- Misses 610 634 +24
- Partials 0 2 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fantastic @marciocadev ! Really excited to have this added to projen. :) I've just added a few small comments.
Co-authored-by: Christopher Rybicki <crybicki98@gmail.com>
Co-authored-by: Christopher Rybicki <crybicki98@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @marciocadev ! 🙏
Just like it was done for Java I made a python cdk project template
I needed to decouple the existing pytest class to create a specific test template for CDK Python projects
Testing against local projects
Testing this solution is a little different as it is necessary import the projen python dependency
Now, to create new projects:
Now you can make some changes on your .projenrc.py file and run
python .projenrc.py
closes #1577
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.