Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(awscdk): integration tests should deploy ** by default instead of * #1524

Merged
merged 1 commit into from
Jan 13, 2022

Conversation

misterjoshua
Copy link
Contributor

@misterjoshua misterjoshua commented Jan 13, 2022

Per discussion in #1496 (comment), ** is a better choice for the default integration test stack to deploy, as using ** targets stacks including those nested in stages.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

Codecov Report

Merging #1524 (8b15f80) into main (d90284c) will increase coverage by 1.17%.
The diff coverage is 88.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1524      +/-   ##
==========================================
+ Coverage   88.06%   89.23%   +1.17%     
==========================================
  Files         132      141       +9     
  Lines        5109     5788     +679     
  Branches     1207     1533     +326     
==========================================
+ Hits         4499     5165     +666     
- Misses        610      621      +11     
- Partials        0        2       +2     
Impacted Files Coverage Δ
src/cdk/consts.ts 100.00% <ø> (+36.36%) ⬆️
src/dev-env.ts 83.33% <0.00%> (ø)
src/java/index.ts 100.00% <ø> (ø)
src/python/index.ts 100.00% <ø> (ø)
src/release/index.ts 100.00% <ø> (ø)
src/typescript/typescript-typedoc.ts 20.00% <0.00%> (ø)
src/web/react.ts 100.00% <ø> (ø)
src/web/tailwind.ts 100.00% <ø> (ø)
src/xmlfile.ts 92.30% <ø> (+0.64%) ⬆️
src/yaml.ts 100.00% <ø> (ø)
... and 157 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9771c1...8b15f80. Read the comment docs.

@misterjoshua misterjoshua marked this pull request as ready for review January 13, 2022 07:06
@mergify mergify bot merged commit 39e3646 into projen:main Jan 13, 2022
@misterjoshua misterjoshua deleted the use-globstar branch January 13, 2022 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants