Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: broken self-mutation step #1520

Merged
merged 2 commits into from
Jan 12, 2022
Merged

fix: broken self-mutation step #1520

merged 2 commits into from
Jan 12, 2022

Conversation

iliapolo
Copy link
Contributor

The position of the -s flag is misplaced, should be before -m.

Fixes #1519


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@iliapolo iliapolo requested a review from eladb January 12, 2022 10:37
@codecov-commenter
Copy link

Codecov Report

Merging #1520 (d532e39) into main (d90284c) will increase coverage by 1.17%.
The diff coverage is 88.40%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1520      +/-   ##
==========================================
+ Coverage   88.06%   89.23%   +1.17%     
==========================================
  Files         132      141       +9     
  Lines        5109     5786     +677     
  Branches     1207     1469     +262     
==========================================
+ Hits         4499     5163     +664     
- Misses        610      621      +11     
- Partials        0        2       +2     
Impacted Files Coverage Δ
src/cdk/consts.ts 100.00% <ø> (+36.36%) ⬆️
src/dev-env.ts 83.33% <0.00%> (ø)
src/java/index.ts 100.00% <ø> (ø)
src/python/index.ts 100.00% <ø> (ø)
src/release/index.ts 100.00% <ø> (ø)
src/typescript/typescript-typedoc.ts 20.00% <0.00%> (ø)
src/web/react.ts 100.00% <ø> (ø)
src/web/tailwind.ts 100.00% <ø> (ø)
src/xmlfile.ts 92.30% <ø> (+0.64%) ⬆️
src/yaml.ts 100.00% <ø> (ø)
... and 157 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f4a6ff...d532e39. Read the comment docs.

@mergify mergify bot merged commit 43ee650 into main Jan 12, 2022
@mergify mergify bot deleted the epolon/self-mutation-broken branch January 12, 2022 11:14
misterjoshua pushed a commit to misterjoshua/projen that referenced this pull request Jan 12, 2022
The position of the `-s` flag is misplaced, should be before `-m`. 

Fixes projen#1519

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Self mutation is broken
3 participants