Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jest): tests are picked up from dist/ #1456

Merged
merged 5 commits into from
Jan 2, 2022
Merged

fix(jest): tests are picked up from dist/ #1456

merged 5 commits into from
Jan 2, 2022

Conversation

eladb
Copy link
Contributor

@eladb eladb commented Jan 2, 2022

Scope down jest's test match pattern to only include tests from src/ and test/.

Fixes #1441

BREAKING CHANGE: The method jest.addTypeScriptSupport() is no longer available. This code is now inside TypeScriptProject.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Scope down jest's test match pattern to only include tests from `src/` and `test/`.

Fixes #1441

BREAKING CHANGE: The method `jest.addTypeScriptSupport()` is no longer available. This code is not inside `TypeScriptProject`.
@eladb eladb requested a review from Chriscbr January 2, 2022 21:51
@mergify mergify bot added the contribution/core ⚙️ used by automation label Jan 2, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 2, 2022

Codecov Report

Merging #1456 (9ec6353) into main (d90284c) will decrease coverage by 0.31%.
The diff coverage is 87.01%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1456      +/-   ##
==========================================
- Coverage   88.06%   87.74%   -0.32%     
==========================================
  Files         132      141       +9     
  Lines        5109     5681     +572     
  Branches     1207     1450     +243     
==========================================
+ Hits         4499     4985     +486     
- Misses        610      694      +84     
- Partials        0        2       +2     
Impacted Files Coverage Δ
src/cdk/consts.ts 100.00% <ø> (+36.36%) ⬆️
src/dev-env.ts 83.33% <0.00%> (ø)
src/java/index.ts 100.00% <ø> (ø)
src/python/index.ts 100.00% <ø> (ø)
src/release/index.ts 100.00% <ø> (ø)
src/typescript/typescript-typedoc.ts 20.00% <0.00%> (ø)
src/yaml.ts 100.00% <ø> (ø)
test/util.ts 96.15% <ø> (+0.26%) ⬆️
src/semver.ts 13.33% <8.33%> (-6.67%) ⬇️
src/task-runtime.ts 12.31% <21.42%> (-0.28%) ⬇️
... and 143 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ef39f8...9ec6353. Read the comment docs.

@mergify mergify bot merged commit 1139411 into main Jan 2, 2022
@mergify mergify bot deleted the benisrae/jest-dist branch January 2, 2022 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core ⚙️ used by automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jest picks up tests from dist/*
3 participants