Remove box_patterns for stable rust 1.23 #44
Conversation
|
Ah, great! It looks like we removed the use of box destructuring in 66a6719#diff-caee7c45e15d65714d3976d059d7ccb2L102. Thanks for the PR! |
|
Thanks for the review! It looks like the Travis failure will be resolved after projectfluent/fluent-langneg-rs#3 is merged and the version get bumped. |
|
Right :) I'll let @zbraniecki review projectfluent/fluent-langneg-rs#3 and then we can move forward here. Thanks again! |
|
@zbraniecki When do you plan to publish a new release of |
|
Hmm, didn't have any strict plan yet. Wanted to wait for us to be ready to release new fluent-rs and release both alongside, but if you see a value in a release soon, I can do that! |
|
If you feel comfortable bumping it to 0.3.1 we could then go ahead and merge this PR. It's a small change which makes it easier to get started with our code. |
|
Thank you for your contributions @ashley-rose ! I released |
As far as I can tell, the fluent crate is not using
box_patterns. I removed the feature declaration, and after projectfluent/fluent-langneg-rs#3 is merged, we should be able to get this building on stable rust 1.23, resolving #42.