Migrate to pin_cell crate #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregtatum
approved these changes
Dec 22, 2022
| @@ -1,97 +0,0 @@ | |||
| #![deny(missing_docs, missing_debug_implementations)] | |||
There was a problem hiding this comment.
Thought: Looks like this will be another vendored crate for Firefox, but it should be direct enough to certify on the next vendoring.
There was a problem hiding this comment.
My logic is that we're not experts to maintain it in-house, so better to vendor no-dep utility
|
Uh oh, this has conflicts that need resolving. |
|
rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that dignifiedquire/pin-cell#6 is resolved, we can migrate to
pin_cell.