Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optionally upload to pdcp cloud #4396

Merged
merged 1 commit into from
Nov 20, 2023
Merged

optionally upload to pdcp cloud #4396

merged 1 commit into from
Nov 20, 2023

Conversation

tarunKoyalwar
Copy link
Member

@tarunKoyalwar tarunKoyalwar commented Nov 20, 2023 •
edited
Loading

Proposed Changes

  • Disable Cloud upload (default) and optionally enable with flags and env

Updates:

+   -cup, -cloud-upload  upload scan results to pdcp dashboard
-   -dcu, -disable-cloud-upload  disable uploading scan results to pdcp
+ ENABLE_CLOUD_UPLOAD
- DISABLE_CLOUD_UPLOAD

@tarunKoyalwar tarunKoyalwar self-assigned this Nov 20, 2023
@tarunKoyalwar tarunKoyalwar linked an issue Nov 20, 2023 that may be closed by this pull request
Results upload should be optional #4388
Closed
@tarunKoyalwar tarunKoyalwar marked this pull request as ready for review November 20, 2023 14:26
@ehsandeep ehsandeep merged commit f1a4410 into dev Nov 20, 2023
12 checks passed
@ehsandeep ehsandeep deleted the issue-4388-optional-upload branch November 20, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

Assignees

@tarunKoyalwar tarunKoyalwar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Results upload should be optional
2 participants
@tarunKoyalwar @ehsandeep