Adding linters and aligning code #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prometherion
force-pushed
the
issues/166
branch
2 times, most recently
from
e038781 to
8c0f9a7
Compare
|
These changes could affect the work in progress by @paolocarta: thanks to the additional linters I discovered the (obvious) duplication of code for the StorageClass, IngressClass, and Registry allowed lists with exact and regex matching. So I decided to perform refactoring of this to avoid the duplication of code, and the result seems neat to me but I could expect some pain performing a rebase of your work on #162: so, if this is going to happen, we can delay this PR after yours. Just let me know! |
prometherion
force-pushed
the
issues/166
branch
2 times, most recently
from
26dcd6e to
4bfbf59
Compare
prometherion
force-pushed
the
issues/166
branch
from
4bfbf59 to
17365e4
Compare
prometherion
force-pushed
the
issues/166
branch
from
17365e4 to
6ee3956
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #166.