-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZAP-generated Matter TV Casting Cluster Commands #32626
Merged
mergify
merged 6 commits into
project-chip:master
from
pgregorr-amazon:zap-ios-part2-2024-03-05
Mar 25, 2024
Merged
ZAP-generated Matter TV Casting Cluster Commands #32626
mergify
merged 6 commits into
project-chip:master
from
pgregorr-amazon:zap-ios-part2-2024-03-05
Mar 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mhazley and
mkardous-silabs
March 19, 2024 00:05
pullapprove
bot
requested review from
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
March 19, 2024 00:05
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the CI failures.
...ting-app/darwin/MatterTvCastingBridge/MatterTvCastingBridge/templates/MCCommandPayloads.zapt
Outdated
Show resolved
Hide resolved
...ng-app/darwin/MatterTvCastingBridge/MatterTvCastingBridge/zap-generated/MCCommandPayloads.mm
Show resolved
Hide resolved
sharadb-amazon
approved these changes
Mar 19, 2024
andy31415
reviewed
Mar 19, 2024
...ting-app/darwin/MatterTvCastingBridge/MatterTvCastingBridge/templates/MCCommandPayloads.zapt
Outdated
Show resolved
Hide resolved
...s/tv-casting-app/darwin/MatterTvCastingBridge/MatterTvCastingBridge/templates/templates.json
Outdated
Show resolved
Hide resolved
...in/MatterTvCastingBridge/MatterTvCastingBridge/templates/partials/command_response_type.zapt
Outdated
Show resolved
Hide resolved
pgregorr-amazon
force-pushed
the
zap-ios-part2-2024-03-05
branch
from
March 22, 2024 20:19
7242c92
to
5b5600f
Compare
PR #32626: Size comparison from 0f9542b to 5b5600f Decreases (2 builds for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
...ting-app/darwin/MatterTvCastingBridge/MatterTvCastingBridge/templates/MCCommandPayloads.zapt
Outdated
Show resolved
Hide resolved
...-app/darwin/MatterTvCastingBridge/MatterTvCastingBridge/templates/MCCommandPayloads-src.zapt
Outdated
Show resolved
Hide resolved
auto-merge was automatically disabled
March 25, 2024 17:04
Head branch was pushed to by a user without write access
pgregorr-amazon
force-pushed
the
zap-ios-part2-2024-03-05
branch
from
March 25, 2024 17:04
5b5600f
to
cc7cd2d
Compare
PR #32626: Size comparison from 04251f1 to cc7cd2d Decreases (2 builds for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
bzbarsky-apple
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change continues the ZAP code generation implementation in examples/tv-casting-app/Darwin/MatterTvCastingBridge for command objects on iOS.
Change summary
Testing
Verified and tested locally with the iOS tv-casting-app example app. After running “./scripts/tools/zap_regen_all.py” and building the iOS example app. The example app connects to the selected Casting Player is able to perform the following cluster actions:
4. Content Launcher cluster Launch URL
5. Application basic cluster Read VendorID
6. Media playback cluster Subscribe to Current state