-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TC-ACE_1.5: Add #30972
TC-ACE_1.5: Add #30972
Conversation
…ad currentfabric and steps 3, 4
… on steps (7,8,9,10)
…pported and expect success all steps added
PR #30972: Size comparison from eeebbbf to 8046742 Increases (3 builds for bl602, bl702, bl702l)
Decreases (1 build for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #30972: Size comparison from eeebbbf to 451df93 Full report (18 builds for cc13x4_26x4, cc32xx, k32w, mbed, nrfconnect, qpg)
|
PR #30972: Size comparison from eeebbbf to 549f5cb Increases above 0.2%:
Increases (17 builds for bl602, bl702, bl702l, linux)
Decreases (3 builds for efr32, linux)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of minor comments, but this looks completely reasonable. Most of the comments are just asking you to clean up stuff that was already done in other scripts, but I think it'll make your life easier in the long run to abstract some of this stuff out.
2 more things to do on this:
- Add the test harness functions - I'll ping you on slack tomorrow with how to do that (or ping me if you get there first)
- Add this test to the CI - that will be in https://github.com/project-chip/connectedhomeip/blob/master/.github/workflows/tests.yaml#L455 - there's a bunch of tests there already. At some point, we should wrap that in a script that does it automatically, but for now, just copy-paste and we can deal with the cleanup at a later date.
Added new random discriminator is store on a dictionary. When is calling onCommissioningWindow method is return as a tuple (CommissioningParameters, random_discriminator)
…dle error onCommissioningWindow
Please see 103
Corresponding test plan [TC-ACE-1.5] Multi-fabric