Factorize memory interfaces implementations #2705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 25, 2024
ithinuel
force-pushed
the
factorize-memory-interfaces-impls
branch
3 times, most recently
from
bd2a530 to
0586b04
Compare
bugadani
reviewed
Jul 25, 2024
changelog/changed-factorize-MemoryInterface-slight-variations.md
Outdated
Show resolved
Hide resolved
ithinuel
force-pushed
the
factorize-memory-interfaces-impls
branch
from
0586b04 to
f1f7b98
Compare
bugadani
reviewed
Jul 25, 2024
This also "backports" `fn write()` from ArmMemoryInterface (formerly ArmProbe) to MemoryInterface as relying on the default implementation showed some test failures. Co-Authored-By: Dániel Buga <bugadani@gmail.com>
ithinuel
force-pushed
the
factorize-memory-interfaces-impls
branch
from
f1f7b98 to
eb208ca
Compare
bugadani
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probe-rs implements in several locations quasi identical version of
probe_rs::memory::MemoryInterface.This factorizes (some of) these ocurrences and reduces code duplication.
While doing this, it was noted that the default implementation of
MemoryInterface::writedidn’t pass allarchitecture::arm::memory::adi_v5_memory_interface::test::*. This fixes the issue by moving the implementation fromAdiMemoryInterface::writeback toMemoryInterface.Follows: