Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Xtensa #2689

Merged
merged 4 commits into from
Jul 21, 2024
Merged

Fix Xtensa #2689

merged 4 commits into from
Jul 21, 2024

Conversation

bugadani
Copy link
Contributor

@bugadani bugadani commented Jul 21, 2024 •
edited
Loading

Regressed in #2674 - Xtensa NARSEL is stateful. Writing DR alternates between NAR and NDR, while writing IR always resets the next write to NAR. This means Xtensa requires that IR is not written in some cases.

This PR adds an "IR-less" write option to fix this issue.

@bugadani bugadani changed the title Try to fix xtensa Fix Xtensa Jul 21, 2024
@bugadani bugadani marked this pull request as ready for review July 21, 2024 12:27
@bugadani bugadani enabled auto-merge July 21, 2024 12:51
@bugadani bugadani added this pull request to the merge queue Jul 21, 2024
Merged via the queue into probe-rs:master with commit 0ed2a84 Jul 21, 2024
20 checks passed
@bugadani bugadani deleted the fix-xtensa branch July 21, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yatekii Yatekii Yatekii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bugadani @Yatekii