Teach target-gen #2543
Closed
Teach target-gen #2543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugadani
added
the
changelog:skip
MabezDev
reviewed
Jun 5, 2024
bugadani
force-pushed
the
refresh
branch
4 times, most recently
from
28da96b to
2908074
Compare
MabezDev
approved these changes
Jun 6, 2024
|
Yeah getting rid of 2MB of raw YAML is always a win. But let's not be hasty, there might be unforseen side effects here. |
I agree, I only tested esp devices 🙈 |
|
I did a spot-review on most of the changes and they seemed fine, but this PR breaks most of the website targets so that part isn't ideal :) I need a green-light from Noah and probably a website patch to deal with this, first. |
noppej
approved these changes
Jun 6, 2024
|
Haha I didn't expect #2540 to significantly impact this idea, but it does. Looks like merging the targets like this is actually not viable, at least not if we want to keep variant |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... to:
pselas hex (makes RP2040 a bit more readable)The idea came while experimenting with STM detection, where the there are myriads of very similar variants of the same chip. probe-rs only cares about memory layouts, core configuration and flash algos currently, so these targets can be merged.
The original target names are preserved under
aliasesand this information can also be used in the future if a "de-deduplicate" command will become necessary. This is not kept for algos because I don't think they are meaningful if separate.In total, this PR removes about 40% (in binary size) of our
targets/folder. The website needs to be adjusted to expand targets based on the aliasses, I think.