-
-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run Command refactoring #2295
Merged
Merged
Run Command refactoring #2295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yatekii
reviewed
Mar 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty much LGTM :) Thanks a lot!
bugadani
reviewed
Mar 19, 2024
bugadani
reviewed
Mar 19, 2024
t-moe
force-pushed
the
run_cmd_refactoring
branch
from
March 20, 2024 07:56
f0d914b
to
43c788b
Compare
MabezDev
approved these changes
Mar 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the run cmd. It does not add any new or change any existing functionality.
The idea is to have a set of RunModes (
NormalRunMode
,TestRunMode
) that vary slightly in their implementation but share a commonRunLoop
(which does the rtt polling and stack trace printing etc).This refactoring will allow me to work on my testing branch, without running into merge conflicts all the time.
This PR also puts headings in the help output.
New `probe-rs run --help` output
Take a look at #2292 to see how this refactoring is the base for the new
TestRunMode