Make logging to file opt-in #1946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugadani
commented
Dec 10, 2023
|
From 50KB/s flashing to 200KB/s on an esp32c6.... 🤯. I also tested the one ARM board I have around, an stm32f2 and that got a nice 10KB/s bump too! |
MabezDev
approved these changes
Dec 10, 2023
Yatekii
approved these changes
Dec 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR turns of file logging by default. It is slow, generates extreme amounts of data and apparently rarely used. Logging to file can now be enabled by two ways:
--log-file <some path>switch--log-to-folder(name pending, feel free to suggest a better one!) in which case the logs are generated into the previously default folder.If logging to file is used, probe-rs now uses
tracing_appender::non_blockingto avoid waiting on file IO if possible.