Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esp-usbjtag: correct reset assert/deassert levels #1922

Merged
merged 1 commit into from
Dec 1, 2023
Merged

esp-usbjtag: correct reset assert/deassert levels #1922

merged 1 commit into from
Dec 1, 2023

Conversation

bugadani
Copy link
Contributor

@bugadani bugadani commented Dec 1, 2023

According to the ESP32-S3 technical reference manual, SRST is high-active. This PR will

  • trigger a JTAG reset when asserting reset (instead of while deasserting)
  • correct the SRST levels so deasserting now pulls the MCU out of reset instead of triggering it

SRST is connected to the reset logic of the digital circuitry in the SoC and a high level on this line
will cause a digital system reset. Note that the USB Serial/JTAG Controller itself is not affected by SRST.

I'm not sure if attach under reset was used for ESP32-Cx devices or if it worked, but the current esp-usbjtag implementation doesn't seem to be correct in this regard.

Copy link
Member

@Yatekii Yatekii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@Yatekii Yatekii added this pull request to the merge queue Dec 1, 2023
Merged via the queue into probe-rs:master with commit 89a71b1 Dec 1, 2023
17 checks passed
@bugadani bugadani deleted the reset branch December 1, 2023 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants