Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error message for ambigous chips #1671

Merged
merged 2 commits into from
Jul 20, 2023
Merged

Better error message for ambigous chips #1671

merged 2 commits into from
Jul 20, 2023

Conversation

k12ish
Copy link
Contributor

@k12ish k12ish commented Jul 14, 2023 •
edited
Loading

Before:

Error: The chip 'stm32l4r5zi' was not found in the database.

Caused by:
    Found multiple chips matching 'stm32l4r5zi', unable to select a single chip.

After:

Error: The chip 'stm32l4r5zi' was not found in the database.

Caused by:
    Found multiple chips matching 'stm32l4r5zi', unable to select a single chip. (STM32L4R5ZITx, STM32L4R5ZITxP, STM32L4R5ZIYx)

This helps beginners like me who don't appreciate the difference between the order code (Nucleo-L4R5ZI) and the actual target board (STM32L4R5ZIT6U)

Yatekii
Yatekii approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@Yatekii Yatekii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thank you very much!

@Yatekii Yatekii added this pull request to the merge queue Jul 20, 2023
Merged via the queue into probe-rs:master with commit e4a3bed Jul 20, 2023
@k12ish k12ish deleted the patch-1 branch July 20, 2023 09:45
@9names 9names mentioned this pull request Jan 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yatekii Yatekii Yatekii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k12ish @Yatekii